PYTHON-2442: Refactor: use _asdict() in _options_dict()#2670
Merged
blink1073 merged 5 commits intomongodb:masterfrom Dec 30, 2025
Merged
PYTHON-2442: Refactor: use _asdict() in _options_dict()#2670blink1073 merged 5 commits intomongodb:masterfrom
blink1073 merged 5 commits intomongodb:masterfrom
Conversation
Replaced manual dictionary creation with the more idiomatic _asdict() method in both CodecOptions and JSONOptions.
Member
|
Hi @RinCodeForge927, thank you for the fix! Looking at the original commit, I think we can remove the private method |
As suggested in PR review, _options_dict is redundant. Replaced its usage in JSONOptions.with_options with _asdict().
Contributor
Author
|
Thanks for the suggestion! I've removed |
Member
|
Looks like at least one more usage needs to be updated based on the docs build failure: |
Following reviewer feedback, the private method _options_dict has been removed from both CodecOptions and JSONOptions. Call sites have been updated to use _asdict() directly.
Contributor
Author
|
I've cleaned up the remaining references to |
blink1073
changed the title
Contributor
Author
|
Thank you for the review! I'm very happy to contribute a small improvement to such a great project. Glad I could help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the TODOs mentioned in PYTHON-2442 by replacing manual dictionary construction in
_options_dict()with calls to_asdict()in bothCodecOptionsandJSONOptions. This is more idiomatic as these classes inherit from NamedTuple (or use its interface).